Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for non-package models #1230

Merged
merged 9 commits into from
Jan 29, 2025
Merged

bug fix for non-package models #1230

merged 9 commits into from
Jan 29, 2025

Conversation

topepo
Copy link
Member

@topepo topepo commented Jan 19, 2025

Closes #1229

@topepo topepo marked this pull request as ready for review January 20, 2025 22:48
@topepo topepo requested a review from hfrick January 28, 2025 12:54
@@ -1,6 +1,7 @@
Version: 1.0
ProjectId: 7f6c9ff5-6b9a-4235-8666-12db5ef65d49
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is changing and I'm working on figuring out why

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because collaborators are using different versions of the IDE. The IDE folks are trying to find a way to avoid this issue.

tests/testthat/test-decision_tree.R Outdated Show resolved Hide resolved
tests/testthat/test-misc.R Show resolved Hide resolved
@topepo
Copy link
Member Author

topepo commented Jan 29, 2025

This comment and the resurrected test are bad merges from the main. A PR previous to this one removed the test (since the expiration date past) without the overall changes.

@topepo topepo merged commit 3b2572c into main Jan 29, 2025
10 checks passed
@topepo topepo deleted the no-pkg branch January 29, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in call2 when using local fit function and omitting pkg
2 participants